Skip to content

fix(Comment Section): Sync theme with site color mode #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

fix(Comment Section): Sync theme with site color mode #820

merged 1 commit into from
Oct 6, 2025

Conversation

@Abhi0049k
Copy link
Contributor

@Abhi0049k Abhi0049k commented Oct 6, 2025 •
edited
Loading

Description

The Giscus component did not update its theme when the site's color mode was toggled. The theme was only set once during the initial script injection.

This change implements the recommended approach for dynamic theme updates by:

  1. Using a hook that runs only once on mount to inject the Giscus script with the initial theme.
  2. Adding a second hook that listens for changes to .
  3. When a change is detected, it sends a to the Giscus iframe to update its theme, ensuring it stays in sync with the site's theme toggle.

Fixes #775 and #773

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Original Behaviour

image

Changes Made

Light Mode
image

Dark Mode
image

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

@Abhi0049k
fix(giscus): Sync theme with site color mode
b072f6d 
The Giscus component did not update its theme when the site's color mode was toggled. The theme was only set once during the initial script injection.

This change implements the recommended approach for dynamic theme updates by:
1.  Using a  hook that runs only once on mount to inject the Giscus script with the initial theme.
2.  Adding a second  hook that listens for changes to .
3.  When a change is detected, it sends a  to the Giscus iframe to update its theme, ensuring it stays in sync with the site's theme toggle.

Fixes recodehive#775
@vercel
Copy link
Contributor

vercel bot commented Oct 6, 2025

@Abhi0049k is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Synced data from Linked Issues

Labels:

  • level 1
  • recode
  • hacktoberfest-accepted

Assignees:

  • Abhi0049k

Milestones:

  • recode:launch 3.0

@github-actions github-actions bot added hacktoberfest-accepted level 1 10 points recode this is label for leaderboard labels Oct 6, 2025
@vercel
Copy link
Contributor

vercel bot commented Oct 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Oct 6, 2025 6:34am

@sanjay-kv sanjay-kv added this to the recode:launch 3.0 milestone Oct 6, 2025
@sanjay-kv sanjay-kv moved this to In Progress in @recode-web Oct 6, 2025
@sanjay-kv
Copy link
Member

sanjay-kv commented Oct 6, 2025

This is a good find @Abhi0049k

@sanjay-kv sanjay-kv merged commit 997121e into recodehive:main Oct 6, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanjay-kv sanjay-kv sanjay-kv approved these changes

Assignees

@Abhi0049k Abhi0049k

Labels

hacktoberfest-accepted level 1 10 points recode this is label for leaderboard

Projects

@recode-web
Status: Done

Milestone

recode:launch 3.0

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Comment section does not apply dark mode styling

2 participants

@Abhi0049k @sanjay-kv